-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add basic web support #2014
base: main
Are you sure you want to change the base?
add basic web support #2014
Conversation
will check asap cc @neooriginal @mdmohsin7 0-10 rating pls |
Honestly I'd rate it 5/10, there are better approaches than this. Although they (better approaches) require a bit more work, but they guarantee better code maintainability |
@b4s36t4 sorry bro 5/10 is too bad |
@b4s36t4 btw I tried "flutter run -d chrome" and still got old flow |
38753cf
to
388ff03
Compare
388ff03
to
0b88da8
Compare
Hi, @kodjima33. I don't agree on rating because there's not much of changes I have done and it's pretty much firebase configuration I have done. anyhow I have made some cleanup to streamline the process. Before proceeding these are the following questions I have.
Let me know what you think? |
Means? just blank screen or any other issue? I have pushed some changes, can you try now? |
@@ -86,7 +86,7 @@ dependencies: | |||
geolocator: | |||
version: ^3.0.2 | |||
webview_flutter: ^4.8.0 | |||
flutter_sound: ^9.10.0 | |||
flutter_sound: 9.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is required, because latest version is causing issues with latest version (https://github.com/Canardoux/flutter_sound_web/blame/b64335b030592f8b36c4459ce2803b3ad29a0ebb/lib/flutter_sound_media_player_web.dart#L83-L86) which works on latest version of web
dependency, but we're using file_picker
which uses 0.5.1
version. I don't want update file_picker
not sure what breaking changes they have. So I had to pin the version.
hey, @kodjima33 let me know when you take a look at this questions. I solved 2nd question issue from the other PR i.e mac support. Regardless of the PR approval that's a small change, can be accommodated easily. |
man, sry but i am not a fan of the fragmented control flow code (if-else), even in the current omi repo. you could do it better with a systematic way to handle platform-specific code. looking forward. |
Hey, @beastoin can you answer above questions please. That would give me more scope to cleanup. Also I don't think there are any new if/else condition that can be extended to other way of multi-platform code. I just don't want to duplicate the whole code and pollute with same repeating stuff. Please answer the above questions that would surely help me clean and remove a lot of if/else. |
What do you mean about the principles? Tell me more about what Flutter supports for web and what do you suggest? For me, web is web, neither Android nor iOS.
Tell me more about the errors if you need my help. Since, with the current Omi backend system, you could use a simple command line to connect to WS. E.g.
Of course, CORS is a must. @b4s36t4 if I were you, I would:
Make it work and keep it simple like that first, then you could add more design patterns to make it cleaner later (if needed). Join us https://discord.omi.me and feel free to dm me @thinh |
Basic web support for omi.
/claim #2008
Working flow
Kapture.2025-03-14.at.07.01.14.mp4