Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename memories to conversations #2017

Merged
merged 20 commits into from
Mar 24, 2025
Merged

rename memories to conversations #2017

merged 20 commits into from
Mar 24, 2025

Conversation

mdmohsin7
Copy link
Member

@mdmohsin7 mdmohsin7 commented Mar 14, 2025

part of #1973

  • move memories_db to conversations_db
  • replace instances of memories_db with conversations_db
  • rename redis memory methods to conversations and update their instances
  • rename memories specific models
  • create new routes for conversations
  • refactor memories utils
  • test all flows in old app with new changes
  • update conversation routes in app

@mdmohsin7 mdmohsin7 changed the title renmae memories to conversations rename memories to conversations Mar 16, 2025
@mdmohsin7 mdmohsin7 marked this pull request as ready for review March 21, 2025 17:25
@mdmohsin7
Copy link
Member Author

mdmohsin7 commented Mar 21, 2025

Deployment Plan:

  • Deploy Backend on Dev Env
  • Deploy App on Dev Env and test all flows one last time
  • Deploy Backend on Prod Env
  • Deploy App on Prod Env

No database changes are required for this PR. The backend is backwards compatible with the app. After 1-2 weeks of releasing this version to prod, the old endpoints and models can be safely deleted permanently

@beastoin pls review

@beastoin
Copy link
Collaborator

lgtm @mdmohsin7

btw before merging, could you create a new PR to the development branch, merge it, then deploy it to dev env and check it ?

if everything works well, come back to me with the result then we will proceed merging on main branch.

@mdmohsin7
Copy link
Member Author

lgtm @mdmohsin7

btw before merging, could you create a new PR to the development branch, merge it, then deploy it to dev env and check it ?

if everything works well, come back to me with the result then we will proceed merging on main branch.

Will do sir, and then will get back to you

@mdmohsin7
Copy link
Member Author

Did not face any issues on the dev deployment. Did see the below two issues in logs but they are not related to my changes as far as I know. The below vad issue was causing problems with local sync (when I closed the app and opened again, the backend kinda got stuck in a loop or something due to this, and it wasn't working until I redeployed the backend again). This very same issue happens if I deploy to dev env from main branch.

Screenshot 2025-03-22 at 10 49 54 PM Screenshot 2025-03-22 at 10 21 37 PM

@beastoin

@beastoin beastoin merged commit 84a1530 into main Mar 24, 2025
@beastoin beastoin deleted the conversations-rename branch March 24, 2025 02:58
@beastoin
Copy link
Collaborator

lgtm @mdmohsin7

vad - nvm, just because you could not connect to the VAD (check your .env > VAD HOST variable)
langsmith - we've already disabled it for a month, var LANGCHAIN_TRACING_V2 - false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants