Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change onboarding #2064

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

krushnarout
Copy link

fixes #2063
/claim #2063

Screen.Recording.2025-03-22.at.8.42.19.AM.mov

@algora-pbc algora-pbc bot mentioned this pull request Mar 22, 2025
@beastoin
Copy link
Collaborator

1/ tell me more about your fixes since Connect to omi -> entering the no device(twitter) flow is really weird, make sure you understand about what should be changed first. if not, lets clarify it. #2063

@krushnarout

@krushnarout
Copy link
Author

clarify the flow

@beastoin Done! Please check.

Connect omi ->

Screen.Recording.2025-03-22.at.10.15.33.AM.mov

I don't have omi ->

Screen.Recording.2025-03-22.at.10.16.44.AM.mov

@krushnarout
Copy link
Author

@beastoin Please review! I've made changes according to the given flow, and it’s working fine!

@beastoin
Copy link
Collaborator

@krushnarout
Copy link
Author

krushnarout commented Mar 24, 2025

1/ ok 2/ why did we need these changes sir ? https://github.com/BasedHardware/omi/pull/2064/files#diff-be78b37404fce4833b2724c446c5e181e04ca6c2c576dfd4f88fa62085642a98L72-L245

@beastoin I made changes according to the design

425634899-f6a2ea98-b447-472b-9fab-53f5adae7ca8

@beastoin
Copy link
Collaborator

2/ ahhh please clarify it with Nik if he needs that changes or not. since for me this task should be the flow.

@krushnarout

and @mdmohsin7 feel free to help with merging ;)

@krushnarout
Copy link
Author

@kodjima33 I updated the flow as per the issue and removed the robot icon based on the design. Just wanted to confirm if the robot icon removal is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix onboarding
2 participants