Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Improve directional diagram algo #113

Merged
merged 3 commits into from
Aug 17, 2024
Merged

Commits on Aug 16, 2024

  1. ENH: Improve directional diagram algo

    * Changes directional diagram algorithm
    to use depth-first-search (i.e. `nx.dfs_tree`)
    to generate the directional edges.
    
    * Removes private functions
    `diagrams._collect_sources` and
    `diagrams.get_directional_path_edges`
    nawtrey committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    0ae72b5 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2024

  1. Update docstring

    nawtrey committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    c202937 View commit details
    Browse the repository at this point in the history
  2. ENH: Update directional diagram algo

    * Use networkx method to build the directional
    diagram with reversed edges
    
    * Move array-based edge flipping code into
    the `return_edges=True` code path
    
    * Changes directional diagram return type
    for `return_edges=False` to a `nx.DiGraph`
    nawtrey committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    5a77ec8 View commit details
    Browse the repository at this point in the history