Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Added extra data to json output #5

Closed
wants to merge 1 commit into from

Conversation

leevigraham
Copy link

  • Scenario File / Line Number
  • Step File / Line Number
  • Step Snippet

Todo:

  • Update .features
  • Update schema

* Scenario File / Line Number
* Step File / Line Number
* Step Snippet
@headrevision
Copy link
Contributor

@leevigraham Good idea. Could you adapt the JSON schema and add two or more scenarios for it?

@leevigraham
Copy link
Author

@headrevision I had a bit more of a play with this and I think it could work. My concern is that the HTML formatter doesn't use hooks but a printer which allows access to the Background etc.

Also given Behat v3 is around the corner is this update worth it?

@stof
Copy link
Member

stof commented May 30, 2014

These formatters are for Behat 2, so I don't think it is worth it

@stof
Copy link
Member

stof commented May 30, 2014

Thus, the existing way is much more flexible as it allows setting the parameters later (assuming the service provider is written properly, i.e. reading parameters at the time of building services, not at the time of registering them) instead of requiring all configuration to be done at the time of registering the provider

@headrevision
Copy link
Contributor

Indeed, these formatters are not yet updated to Behat 3, see #6.

@leevigraham Anyway, feel free to finish this PR if you need those extensions to the JSON. If not, I agree with @stof.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants