Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cucumber update 18.1.0 #231

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Cucumber update 18.1.0 #231

merged 2 commits into from
Apr 7, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 7, 2021

[18.1.0] - 2021-04-06

Added

  • Python implementation re-enabled%2C with support for Rule keyword.
    (#1449
    [brasmusson])

Fixed

  • Update translation of Rule in Czech.
    (#1442
    [plavcik])

@stof stof closed this Apr 7, 2021
@stof stof reopened this Apr 7, 2021
@stof
Copy link
Member

stof commented Apr 7, 2021

rule_with_tag.feature probably needs to be added to the exclusion list. Am I right @ciaranmcnulty ?

@ciaranmcnulty
Copy link
Contributor

@stof yes, and I think it's covered by the existing open issue #140

@stof
Copy link
Member

stof commented Apr 7, 2021

@ciaranmcnulty what I mean is that the gherkin 18.0 release seems to include a new feature file that we need to exclude, to make the CI green to merge that

@ciaranmcnulty
Copy link
Contributor

I understand, I just mean we don't need to open a new issue to cover the feature mismatch

@stof stof mentioned this pull request Apr 7, 2021
@stof stof merged commit 603b13f into master Apr 7, 2021
@stof stof deleted the cucumber-update-18.1.0 branch April 7, 2021 12:40
@@ -196,7 +196,7 @@
'given' => 'Za předpokladu|Pokud|*',
'name' => 'Czech',
'native' => 'Česky',
'rule' => 'Rule',
'rule' => 'Pravidlo',
Copy link
Contributor

@ciaranmcnulty ciaranmcnulty Apr 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a break because we don't yet support the keyword

@ciaranmcnulty
Copy link
Contributor

Thanks @stof

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants