Use hardcoded path to i18n file if not provided #290
Conversation
Co-authored-by: Christophe Coevoet <[email protected]>
There was a problem hiding this comment.
I think this is a good solution, but maybe we should also revert moving the files in the src directory, at least for now?
Otherwise it will only work if we release Gherkin and Behat at the same time (and bump the minimum version requirement in Behat).
Also Behat may not be the only thing using this class with a path to the Gherkin i18n file - I'm not sure the limited benefit we get from flattening the directory structure is worth even a small risk of causing problems for other people?
| { | ||
| parent::__construct(include $file); | ||
| parent::__construct(include $file ?? self::I18N_FILE_LOCATION); |
There was a problem hiding this comment.
should we change this to require while we're here? include would still fail if the file didn't exist, as the false wouldn't match the array typehint on the parent constructor - but require would give a better error message?
Alternate solution to the problem described in Behat/Behat#1602 and Behat/Behat#1603. Since the file that
CachedArrayKeywordsneeds to load is in the same package, it does not need to be told its location by another package. We keep the option of passing a file name in case someone is using this class to load an i18n file from some other location. After this is merged in this package we should update Behat so that it does not attempt to provide the path to the file