fix(api): update reorg handling procedure #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
🦋 Changeset detectedLatest commit: 80a8e6e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #713 +/- ##
==========================================
- Coverage 88.60% 88.58% -0.03%
==========================================
Files 162 162
Lines 11059 11060 +1
Branches 1208 1207 -1
==========================================
- Hits 9799 9797 -2
- Misses 1260 1263 +3 ☔ View full report in Codecov by Sentry. |
📦 Next.js Bundle Analysis for @blobscan/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
PJColombo
force-pushed
the
fix/api/reorg-handling
branch
from
40b6bc1 to
80a8e6e
Compare
This was referenced Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
It renames the
handleReorgedSlotsprocedure tohandleReorg.Now, the procedure receives two sets of block hashes: rewinded and forwarded blocks.
• Rewinded blocks represent the blocks from the old chain that are being reverted. These are the blocks being marked as reorg now
• Forwarded blocks belong to the new canonical chain and have been validated starting from the common ancestor between the two chains. If any of these blocks were previously marked as part of a reorg, they are now unmarked.
With the new
forwardedBlocksparameter, we can explicitly designate which blocks belong to the canonical chain, allowing us to unmark them as reorgs if they were previously marked. This eliminates the need to automatically perform this step in theindexDataprocedure as a precaution for reindexed blocks that were previously considered part of a reorg.Motivation and Context (Optional)
This endpoint is necessary for the new handling logic introduced in the indexer.
Related Issue (Optional)
Indexer's PR
Screenshots (if appropriate):