Merge pull request #24 from BoBoBaSs84/fix/bindable-property-and-noti…

…fy-property-do-not-work-with-enums

fix: Bindable property and notify property do not work with enums

Directory.Build.props

@@ -2,8 +2,8 @@
 
   <PropertyGroup>
     <VersionMajor>1</VersionMajor>
-    <VersionMinor>3</VersionMinor>
-    <VersionPatch>1</VersionPatch>
+    <VersionMinor>4</VersionMinor>
+    <VersionPatch>0</VersionPatch>
     <VersionPrefix>$(VersionMajor).$(VersionMinor).$(VersionPatch)</VersionPrefix>
     <VersionSuffix Condition="$(Configuration.Equals('Debug'))">Development</VersionSuffix>
   </PropertyGroup>

src/BB84.Notifications/BindableProperty.cs

@@ -7,7 +7,7 @@ namespace BB84.Notifications;
 /// The bindable property class.
 /// </summary>
 /// <typeparam name="T">The value type to work with.</typeparam>
-public sealed class BindableProperty<T> : IBindableProperty<T> where T : IEquatable<T>
+public sealed class BindableProperty<T> : IBindableProperty<T>
 {
   private T _value;
 

src/BB84.Notifications/Components/BindablePropertyChangedEventArgs.cs

@@ -8,7 +8,7 @@ namespace BB84.Notifications.Components;
 /// The bindable property changed event args class.
 /// </summary>
 /// <typeparam name="T">The value type to work with.</typeparam>
-public sealed class BindablePropertyChangedEventArgs<T> : EventArgs where T : IEquatable<T>
+public sealed class BindablePropertyChangedEventArgs<T> : EventArgs
 {
   /// <summary>
   /// Initializes a instance of the bindable property changed event args class.
@@ -30,4 +30,4 @@ public BindablePropertyChangedEventArgs(T value)
 /// <param name="sender">The source of the event.</param>
 /// <param name="e">The argument that contains the event data.</param>
 [SuppressMessage("Naming", "CA1711", Justification = "Event Handler Naming Conventions")]
-public delegate void BindablePropertyChangedEventHandler<T>(object? sender, BindablePropertyChangedEventArgs<T> e) where T : IEquatable<T>;
+public delegate void BindablePropertyChangedEventHandler<T>(object? sender, BindablePropertyChangedEventArgs<T> e);

src/BB84.Notifications/Components/BindablePropertyChangingEventArgs.cs

@@ -8,7 +8,7 @@ namespace BB84.Notifications.Components;
 /// The bindable property changing event args class.
 /// </summary>
 /// <typeparam name="T">The value type to work with.</typeparam>
-public class BindablePropertyChangingEventArgs<T> : EventArgs where T : IEquatable<T>
+public class BindablePropertyChangingEventArgs<T> : EventArgs
 {
   /// <summary>
   /// Initializes a instance of the bindable property changing event args class.
@@ -30,4 +30,4 @@ public BindablePropertyChangingEventArgs(T value)
 /// <param name="sender">The source of the event.</param>
 /// <param name="e">The argument that contains the event data.</param>
 [SuppressMessage("Naming", "CA1711", Justification = "Event Handler Naming Conventions")]
-public delegate void BindablePropertyChangingEventHandler<T>(object? sender, BindablePropertyChangingEventArgs<T> e) where T : IEquatable<T>;
+public delegate void BindablePropertyChangingEventHandler<T>(object? sender, BindablePropertyChangingEventArgs<T> e);

src/BB84.Notifications/Interfaces/IBindableProperty.cs

@@ -6,7 +6,7 @@ namespace BB84.Notifications.Interfaces;
 /// The bindable property interface.
 /// </summary>
 /// <typeparam name="T">The value type to work with.</typeparam>
-public interface IBindableProperty<T> where T : IEquatable<T>
+public interface IBindableProperty<T>
 {
   /// <summary>
   /// The actual value of the bindable property.

src/BB84.Notifications/NotifyPropertyBase.cs

@@ -26,7 +26,7 @@ public abstract class NotifyPropertyBase : INotifyPropertyBase
   /// <param name="fieldValue">The referenced field.</param>
   /// <param name="newValue">The new value for the property.</param>
   /// <param name="propertyName">The name of the calling property.</param>
-  protected void SetProperty<T>(ref T fieldValue, T newValue, [CallerMemberName] string propertyName = "") where T : IEquatable<T>
+  protected void SetProperty<T>(ref T fieldValue, T newValue, [CallerMemberName] string propertyName = "")
   {
     if (!EqualityComparer<T>.Default.Equals(fieldValue, newValue))
     {
@@ -44,7 +44,7 @@ protected void SetProperty<T>(ref T fieldValue, T newValue, [CallerMemberName] s
   /// </remarks>
   /// <param name="propertyName">The name of the calling property.</param>
   /// <param name="value">The value of the calling property.</param>
-  private void RaisePropertyChanged(string propertyName, object value)
+  private void RaisePropertyChanged(string propertyName, object? value)
     => PropertyChanged?.Invoke(this, new(propertyName, value));
 
   /// <summary>
@@ -55,6 +55,6 @@ private void RaisePropertyChanged(string propertyName, object value)
   /// </remarks>
   /// <param name="propertyName">The name of the calling property.</param>
   /// <param name="value">The value of the calling property.</param>
-  private void RaisePropertyChanging(string propertyName, object value)
+  private void RaisePropertyChanging(string propertyName, object? value)
     => PropertyChanging?.Invoke(this, new(propertyName, value));
 }