feat: do some refactoring (#145)

.github/workflows/ci.yml

@@ -8,7 +8,7 @@ on:
 
 jobs:
   build:
-    runs-on: windows-latest
+    runs-on: ubuntu-latest
 
     steps:
     - name: Checkout

src/BB84.Notifications/NotifiableObject.cs

@@ -124,13 +124,13 @@ private void FillCaches()
     foreach (PropertyInfo propertyInfo in propertiesInfos)
     {
       NotifyChangedAttribute? changedAttribute =
-        propertyInfo.GetCustomAttribute(typeof(NotifyChangedAttribute), false) as NotifyChangedAttribute;
+        propertyInfo.GetCustomAttribute<NotifyChangedAttribute>(false);
 
       if (changedAttribute is not null)
         _propertiesToNotifyOnChange.Add(propertyInfo.Name, changedAttribute.Properties);
 
       NotifyChangingAttribute? changingAttribute =
-        propertyInfo.GetCustomAttribute(typeof(NotifyChangingAttribute), false) as NotifyChangingAttribute;
+        propertyInfo.GetCustomAttribute<NotifyChangingAttribute>(false);
 
       if (changingAttribute is not null)
         _propertiesToNotifyOnChanging.Add(propertyInfo.Name, changingAttribute.Properties);

tests/BB84.NotificationsTests/NotifiablePropertyTests.IsDefault.cs

@@ -1,5 +1,4 @@
 using BB84.Notifications;
-using BB84.Notifications.Interfaces;
 
 namespace BB84.NotificationsTests;
 
@@ -16,7 +15,7 @@ public sealed partial class NotifiablePropertyTests
   [DataRow(default, true)]
   public void IsDefault(object value, bool expected)
   {
-    INotifiableProperty<object> bindableProperty = new NotifiableProperty<object>(value);
+    NotifiableProperty<object> bindableProperty = new(value);
 
     Assert.AreEqual(expected, bindableProperty.IsDefault);
   }
@@ -27,7 +26,7 @@ public void IsDefault(object value, bool expected)
   [DataRow(default, true)]
   public void IsDefaultInteger(int value, bool expected)
   {
-    INotifiableProperty<int> bindableProperty = new NotifiableProperty<int>(value);
+    NotifiableProperty<int> bindableProperty = new(value);
 
     Assert.AreEqual(expected, bindableProperty.IsDefault);
   }
@@ -38,7 +37,7 @@ public void IsDefaultInteger(int value, bool expected)
   [DataRow(default, true)]
   public void IsDefaultNullableInteger(int? value, bool expected)
   {
-    INotifiableProperty<int?> bindableProperty = new NotifiableProperty<int?>(value);
+    NotifiableProperty<int?> bindableProperty = new(value);
 
     Assert.AreEqual(expected, bindableProperty.IsDefault);
   }

tests/BB84.NotificationsTests/NotifiablePropertyTests.IsNull.cs

@@ -16,7 +16,7 @@ public sealed partial class NotifiablePropertyTests
   [DataRow(null, true)]
   public void IsNull(object? value, bool expected)
   {
-    INotifiableProperty<object?> bindableProperty = new NotifiableProperty<object?>(value);
+    NotifiableProperty<object?> bindableProperty = new(value);
 
     Assert.AreEqual(expected, bindableProperty.IsNull);
   }

tests/BB84.NotificationsTests/NotifiablePropertyTests.cs

@@ -6,8 +6,13 @@ namespace BB84.NotificationsTests;
 [TestClass]
 public sealed partial class NotifiablePropertyTests
 {
-  private sealed class TestClass(int bindableProperty)
+  private sealed class TestClass(int bindableProperty) : ITestClass
   {
     public INotifiableProperty<int> BindableProperty { get; set; } = new NotifiableProperty<int>(bindableProperty);
   }
+
+  private interface ITestClass
+  {
+    INotifiableProperty<int> BindableProperty { get; set; }
+  }
 }

tests/BB84.NotificationsTests/ReversiblePropertyTests.cs

@@ -24,11 +24,16 @@ public void ReversiblePropertyTest()
     Assert.AreEqual(default, testClass.Property.Value);
   }
 
-  private sealed class TestClass(int propertyValue)
+  private sealed class TestClass(int propertyValue) : ITestClass
   {
     public TestClass() : this(default)
     { }
 
     public IReversibleProperty<int> Property { get; set; } = new ReversibleProperty<int>(propertyValue);
   }
+
+  private interface ITestClass
+  {
+    IReversibleProperty<int> Property { get; set; }
+  }
 }