Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dynamic styles are mapped to bindings when generating builder #1673

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jan 30, 2025

Description

Please provide the following information:

The Builder generator does not properly format bound styles. This results in bound styles in media queries not functioning.

Minimal repro: https://mitosis.builder.io/playground/?code=JYWwDg9gTgLgBAbzgVwM4FMDKNrrgXzgDMoIQ4AiAAQCNlgAbAE3SgDpgIB6EYHVYKgoBuAFCj0AD0iw4LIgENkDeEWQA7AMYxO6uAFkAngGEykdenUwAFGFJhUASkSi4cTRHWp43hTDwAvCgY2LjWSB4M0ABccADkUOhMcQSO4m6JMMhQetaubnAAPEzAAG75BXDehgzoAQgIFZWUVCBJwApw1iAKkgC0AO7ATDAAFrEAjABMAAwzYJKOFLEREFFQsb7%2BbJHQBE1u%2BPhNAHxNhVwlpWdujmL4QA

(For output select "Builder")

Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:

  • format the codebase: from the root, run yarn fmt:prettier.
  • update all snapshots (in core & CLI): from the root, run yarn test:update
  • add Changeset entry: from the root, run yarn g:changeset and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.

Copy link

changeset-bot bot commented Jan 30, 2025

🦋 Changeset detected

Latest commit: d34b64d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@builder.io/mitosis Patch
@builder.io/mitosis-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@liamdebeasi liamdebeasi marked this pull request as draft January 30, 2025 21:11
Copy link

nx-cloud bot commented Jan 30, 2025

View your CI Pipeline Execution ↗ for commit d34b64d.

Command Status Duration Result
nx e2e @builder.io/e2e-app ✅ Succeeded 1m 10s View ↗
nx run-many --target test ✅ Succeeded 4m 38s View ↗
nx run-many --target build --exclude @builder.i... ✅ Succeeded 3m 45s View ↗
nx build @builder.io/mitosis-site ✅ Succeeded 2m 19s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-30 22:07:07 UTC

@liamdebeasi liamdebeasi changed the title test fix: dynamic styles are mapped to bindings when generating builder Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant