-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feat: added demuxer
module
#1662
Open
steel-bucket
wants to merge
1
commit into
CCExtractor:master
Choose a base branch
from
steel-bucket:migration-demuxer-module
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP] feat: added demuxer
module
#1662
steel-bucket
wants to merge
1
commit into
CCExtractor:master
from
steel-bucket:migration-demuxer-module
+3,930
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit cbd8e27...:
All tests passing on the master branch were passed completely. NOTE: The following tests have been failing on the master branch as well as the PR:
Check the result page for more info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
In this PR, I have attempted to port the large
demuxer
module to Rust, the primary logic of the heavily interconnected C librariesfile_functions.c
,ccx_gxf.c
,ccx_demuxer.c
and their corresponding header files has aleady been implemented here. There's one more C library, theccx_demuxer_mxf.c
but It was not connected to this, so it could be easily implemented later. I am using a step by step method in which the first step is to uselibc
to write all the logic, which I have done here. After this I'll replacelibc
wherever it is used with inbuilt rust functions to ensure memory safety. Only after that I'll be directly calling them through C and then writing tests. This PR was inspired by the ones done for the 708 Decoder in CCextractor.Any criticism or suggestion is wholeheartedly welcome, I'll be working on this further.