Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Clarify CEA-608/708 Subtitle Extraction Behavior #1448 #1663

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

tank0nf
Copy link
Contributor

@tank0nf tank0nf commented Feb 14, 2025

Referring to issue #1448

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

This pull request addresses the issue where the default behavior of ccextractor changed in version 0.94 regarding CEA-608 and CEA-708 subtitle extraction, but this change was not clearly documented.

Changes:

  • Added a "Subtitle Extraction" section to the --help output in params.c to explain that ccextractor now extracts both CEA-608 and CEA-708 subtitles by default, resulting in two output files when both are present. The section also explains how to use the -1, -2, -12, and -svc options to control which subtitle types are extracted.
  • Updated CHANGES.TXT to include a more detailed description of the change in subtitle extraction behavior.

This change improves the user experience by providing clear and accessible information about the new default behavior, preventing confusion and ensuring that users can easily control subtitle extraction according to their needs.

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit cbd8e27...:

Report Name Tests Passed
Broken 0/13
CEA-708 0/14
DVB 0/7
DVD 0/3
DVR-MS 0/2
General 0/27
Hauppage 0/3
MP4 0/3
NoCC 0/10
Options 0/86
Teletext 0/21
WTV 0/13
XDS 0/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:


Check the result page for more info.

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit cbd8e27...:

Report Name Tests Passed
Broken 13/13
CEA-708 14/14
DVB 7/7
DVD 3/3
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 86/86
Teletext 21/21
WTV 13/13
XDS 34/34

All tests passing on the master branch were passed completely.

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

@cfsmp3 cfsmp3 merged commit ffe075b into CCExtractor:master Feb 14, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants