wip: move stats as stream #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzacharo
force-pushed
the
move-stats-as-stream
branch
from
423a960
to
6be5252
Compare
zzacharo
force-pushed
the
move-stats-as-stream
branch
from
6be5252
to
a19034a
Compare
zzacharo
force-pushed
the
move-stats-as-stream
branch
from
a19034a
to
34bc577
Compare
zzacharo
commented
Oct 18, 2024
| @@ -206,7 +206,7 @@ def publish_and_mint_recid(draft, version): | |||
| record = publish_and_mint_recid(draft, version) | |||
| # Force the created date. This can be done after publish as the service | |||
| # overrides the `created` date otherwise. | |||
| self._load_model_fields(record) | |||
| self._load_model_fields(record, entry) | |||
There was a problem hiding this comment.
that fixes the creation date
zzacharo
commented
Oct 18, 2024
|
|
||
| logger.info("Done!") | ||
|
|
||
| def validate_stats_for_recid(self, recid, record, event_type): |
There was a problem hiding this comment.
That is actually validating that each record stats is equal in both systems
zzacharo
force-pushed
the
move-stats-as-stream
branch
from
3587783
to
6d8674a
Compare
kpsherva
reviewed
Oct 18, 2024
| extra_data["migration"]["source"] = "RECORD, EMAIL NOT FOUND IN ANY SOURCE" | ||
| logger_users.warning(f"User {email} not found.") | ||
| extra_data["migration"]["note"] = "MIGRATED INACTIVE ACCOUNT" | ||
| extra_data["migration"]["note"] = "MIGRATED INACTIVE ACCOUNT" |
There was a problem hiding this comment.
can you revert the tab? it was in correct block before
kpsherva
reviewed
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.