Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create the ion cannon #65

Merged
merged 34 commits into from
Jun 2, 2024
Merged

Create the ion cannon #65

merged 34 commits into from
Jun 2, 2024

Conversation

legokidlogan
Copy link
Member

No description provided.

@legokidlogan legokidlogan added the enhancement New feature or request label May 18, 2024
@legokidlogan legokidlogan self-assigned this May 18, 2024
legokidlogan added 19 commits May 19, 2024 10:35
@legokidlogan
Fix charge gun prediction
23495c7
@legokidlogan
Use bullet callback for the explosion
722370c
@legokidlogan
Tweak explosion visuals
3a431e3
@legokidlogan
Further reduce explosion visual to better match main area of damage
4d0006c
@legokidlogan
Increase explosion radius
6c8ef32
@legokidlogan
Fix nil error
12ce4fb
@legokidlogan
Prevent collisions with owner
80224a1
@legokidlogan
Manually compensate lag
c98e8f7
@legokidlogan
Optimize
f2c9037
@legokidlogan
Properly deny holster while releasing
cc0f107
@legokidlogan
Add one-time hints for the ion cannon, bonk shotgun, and shaped charge
f51c305
@legokidlogan
Auto-create convars to persist hint seen status across sessions
58804b8
@legokidlogan
Add first-time hint for the trash blaster
a632afd
@legokidlogan
Default functions
eee30b6
@legokidlogan
Fix owner charge step sound
2895180
@legokidlogan
Create charge sprite
caf12bc
@legokidlogan
Fix sound and step callback not running for final charge
e26284f
@legokidlogan
Fix sprite sometimes appearing full size for one tick
11bf7cc
@legokidlogan
Tweak ion cannon charge sprite
a6276d9
brandonsturgeon
brandonsturgeon approved these changes Jun 2, 2024
View reviewed changes
Copy link
Member

@brandonsturgeon brandonsturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions, and some code cleanup 👍

lua/weapons/cfc_ion_cannon/shared.lua Outdated Show resolved Hide resolved
lua/weapons/cfc_ion_cannon/shared.lua Outdated Show resolved Hide resolved
lua/weapons/cfc_ion_cannon/shared.lua Outdated Show resolved Hide resolved
lua/weapons/cfc_ion_cannon/shared.lua Outdated Show resolved Hide resolved
lua/weapons/cfc_ion_cannon/shared.lua Outdated Show resolved Hide resolved
lua/weapons/cfc_ion_cannon/shared.lua Outdated Show resolved Hide resolved
lua/weapons/cfc_ion_cannon/shared.lua Outdated Show resolved Hide resolved
lua/weapons/cfc_trash_blaster/shared.lua Show resolved Hide resolved
@legokidlogan legokidlogan merged commit 2fba8c2 into main Jun 2, 2024
1 check passed
@legokidlogan legokidlogan deleted the feature/ion-cannon branch June 2, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TankNut TankNut TankNut left review comments

@brandonsturgeon brandonsturgeon brandonsturgeon approved these changes

@wrefgtzweve wrefgtzweve wrefgtzweve left review comments

Assignees

@legokidlogan legokidlogan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legokidlogan @TankNut @brandonsturgeon @wrefgtzweve