-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project 4: Grace Gilbert #4
Open
gracelgilbert
wants to merge
29
commits into
CIS565-Fall-2019:master
Choose a base branch
from
gracelgilbert:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gracelgilbert
commented
Oct 9, 2019
- Repo Link
- Features
- Vulkan grass and compute pipeline setup
- Grass tessellation and rendering
- Physics simulation on blades
- Gravity
- Recovery
- Wind (noise, sinusoidal, radial)
- Culling
- Orientation
- Frustum
- Distance
- Performance Analysis
- I think a little bit more background on the Vulkan pipeline would have helped me through some of the setup stages. I struggled to figure out the inputs and outputs of the compute and tessellation shaders, so discussing these in a application oriented way may have helped. I also think it would have helped to connect the base code to the Vulkan pipeline a little more, pointing out which parts of the base code are performing which parts of the pipeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.