Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repo Link
Features:
Grass compute and graphics pipeline (featuring tessellation)
Physics sim (wind, gravity, recovery forces)
Three culling heuristics (orientation, frustum, distance)
Feedback:
It's not a bad project, and I personally think the topic (real-time grass rendering) and learning objectives (Vulkan, compute shader, and tessellation) are cool. But...this project is really hard to start. I know we went over Vulkan in the project recitation, but just going over Vulkan specific terms (descriptor set layout, descriptor set, etc, etc) is kinda meaningless and hard to follow. Maybe start with an overview of the project and actually go into the code and be like "look, here's how you would do a descriptor set for a generic model, look it has a model buffer and a sampler."