BCDA-8631: Create group lambda #1039
Conversation
laurenkrugen-navapbc
had a problem deploying
to
dev
GitHub Actions
Failure
|
And a reminder that the workflows wont work until you have created/merged the supporting infrastructure in ab2d-bcda-dpc-platform. |
laurenkrugen-navapbc
had a problem deploying
to
dev
GitHub Actions
Failure
yup! have a PR open on that one as well. |
bcda/lambda/create_group/main.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| } else if match, err := regexp.MatchString("[0-9a-f]{6}-([0-9a-f]{4}-){3}[0-9a-f]{12}", data.ACO_ID); err == nil && match { |
There was a problem hiding this comment.
Nit: Do we want/need to support uuids? It seems like by far the less useful form?
There was a problem hiding this comment.
This also caught my eye too. We end up just using the CMS ID at the end of the operation and not using the UUID, except to validate the ACO. I was going to throw out the UUID but I think it's possible the SGAs use them when creating groups. I'd be happy to remove but I think we would just need to give them a heads up that group creation may change.
There was a problem hiding this comment.
SGAs wont be using our lambdas though right?
Im also noticing that you are calling using a SSASClient to call CreateGroup(), I had to a lot of set up to get that working on my create aco creds branch: https://github.com/CMSgov/bcda-app/pull/1038/files (setting up a variety of env vars). This client eventually sends requests to SSAS api, which is currently timing out, related ticket: https://jira.cms.gov/browse/PLT-903
laurenkrugen-navapbc
had a problem deploying
to
dev
GitHub Actions
Failure
laurenkrugen-navapbc
had a problem deploying
to
dev
GitHub Actions
Failure
laurenkrugen-navapbc
had a problem deploying
to
dev
GitHub Actions
Failure
laurenkrugen-navapbc
temporarily deployed
to
dev
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
dev
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
dev
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
dev
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
dev
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
dev
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
dev
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
dev
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
dev
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
dev
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
dev
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
dev
GitHub Actions
Inactive
🎫 Ticket
https://jira.cms.gov/browse/BCDA-8631
🛠 Changes
Lambda has been added so that we can call it to create groups, ad hoc.
ℹ️ Context
Done as part of the effort to migrate away from jenkins.
🧪 Validation
Tests & workflows passing; additional testing blocked until lambda can be deployed.