Parwinder/bcda-8627-archive cleanup job migration #1042
+715
−529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhagatparwinder
commented
Feb 5, 2025
bhagatparwinder
commented
Feb 5, 2025
austincanada
reviewed
Feb 5, 2025
austincanada
reviewed
Feb 7, 2025
|
What is our testing strategy going to be for making sure these files are being cleaned up properly? Can we stick a bunch of files into EFS to test? They will need to match up with expired jobs right? |
To test it in DEV/TEST environment, I believe that is the route we will have to take. We will have to find out:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/BCDA-8627
🛠 Changes
Updated River Client to set archive cleanup periodic job.
ℹ️ Context