-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BFD-3665 - Populate Tags in FHIR Resource #2512
Conversation
cd716cc
to
ec14071
Compare
f750fdc
to
c2c5921
Compare
BFD-3665 updating comments
...er/bfd-server-war/src/main/java/gov/cms/bfd/server/war/commons/LookUpSamhsaSecurityTags.java
Outdated
Show resolved
Hide resolved
BFD-3665 moving security tag check to before building transformClaim
...er/bfd-server-war/src/main/java/gov/cms/bfd/server/war/commons/LookUpSamhsaSecurityTags.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the output needs to be adjusted a bit. A SAMHSA tag should have a security
section that looks like this:
"meta":{
"security":[
{
"system":"http://terminology.hl7.org/CodeSystem/v3-Confidentiality",
"code":"R",
"display":"Restricted"
},
{
"system":"http://terminology.hl7.org/CodeSystem/v3-ActCode",
"code":"42CFRPart2",
"display":"42 CFR Part 2"
}
]
}
and non-SAMHSA would be
"meta":{
"security":[
{
"system":"http://terminology.hl7.org/CodeSystem/v3-Confidentiality",
"code":"N",
"display":"Normal"
}
]
}
updating the 42CFRPart2 tag display
apps/bfd-server/bfd-server-war/src/test/resources/endpoint-responses/v1/eobByPatientIdAll.json
Show resolved
Hide resolved
...d-server/bfd-server-war/src/main/java/gov/cms/bfd/server/war/commons/SecurityTagManager.java
Outdated
Show resolved
Hide resolved
...d-server/bfd-server-war/src/main/java/gov/cms/bfd/server/war/commons/SecurityTagManager.java
Outdated
Show resolved
Hide resolved
...d-server/bfd-server-war/src/main/java/gov/cms/bfd/server/war/commons/SecurityTagManager.java
Outdated
Show resolved
Hide resolved
.../bfd-server-war/src/main/java/gov/cms/bfd/server/war/r4/providers/HHAClaimTransformerV2.java
Outdated
Show resolved
Hide resolved
...d-server-war/src/test/java/gov/cms/bfd/server/war/stu3/providers/SecurityTagManagerTest.java
Outdated
Show resolved
Hide resolved
corrected url
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the security tags!
JIRA Ticket:
BFD-3665
What Does This PR Do?
Populate Tags in FHIR Resource:
The update will retrieve the security code associated with the claim ID from one of the security tag tables. If a record with either the tag "R" or "42CFRPart2" is found, the security tag will be marked as restricted. If neither of these tags is found, the security tag will be displayed as normal.
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependencies
Modifies any security controls
Adds new transmission or storage of data
Any other changes that could possibly affect security?
I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (
@sb-benohe
) approval.)Validation
Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.
This has been tested with a few tags and unit tests