Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BFD-3665 - Populate Tags in FHIR Resource #2512

Merged
merged 16 commits into from
Jan 24, 2025
Merged

Conversation

MahiFentaye
Copy link
Contributor

@MahiFentaye MahiFentaye commented Dec 16, 2024

JIRA Ticket:
BFD-3665

What Does This PR Do?

Populate Tags in FHIR Resource:

The update will retrieve the security code associated with the claim ID from one of the security tag tables. If a record with either the tag "R" or "42CFRPart2" is found, the security tag will be marked as restricted. If neither of these tags is found, the security tag will be displayed as normal.

image image

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies

  • Modifies any security controls

  • Adds new transmission or storage of data

  • Any other changes that could possibly affect security?

  • I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (@sb-benohe) approval.)

Validation

Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.

This has been tested with a few tags and unit tests

BFD-3665 getting security tags for claim
adding to the response claim, claimResponse, EOB V1
BFD-3665 getting security tags for claim
adding to the response claim, claimResponse, EOB V1
BFD-3665 moving security tag check  to before building transformClaim
@MahiFentaye MahiFentaye marked this pull request as ready for review January 7, 2025 14:44
@MahiFentaye MahiFentaye changed the title BFD-3665 BFD-3665 - Populate Tags in FHIR Resource Jan 8, 2025
Copy link
Contributor

@aschey-forpeople aschey-forpeople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the output needs to be adjusted a bit. A SAMHSA tag should have a security section that looks like this:

"meta":{
      "security":[
         {
            "system":"http://terminology.hl7.org/CodeSystem/v3-Confidentiality",
            "code":"R",
            "display":"Restricted"
         },
         {
            "system":"http://terminology.hl7.org/CodeSystem/v3-ActCode",
            "code":"42CFRPart2",
            "display":"42 CFR Part 2"
         }
      ]
   }

and non-SAMHSA would be

"meta":{
      "security":[
         {
            "system":"http://terminology.hl7.org/CodeSystem/v3-Confidentiality",
            "code":"N",
            "display":"Normal"
         }
      ]
   }

@MahiFentaye MahiFentaye marked this pull request as draft January 10, 2025 14:37
BFD-3665 security tag output updated
renamed class to SecurityTagManager and updated code and unit tests
BFD-3665 updating unit test resources
updating the 42CFRPart2 tag display
@MahiFentaye MahiFentaye marked this pull request as ready for review January 15, 2025 19:12
@MahiFentaye MahiFentaye marked this pull request as draft January 21, 2025 13:53
refactored enum and update libraries and created constants for the urls
BFD-2665 converting to constructor injection and
BFD-3665 adding Samhsa test coverage
some refactor
@MahiFentaye MahiFentaye marked this pull request as ready for review January 23, 2025 22:57
Copy link
Contributor

@alex-dzeda alex-dzeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the security tags!

@MahiFentaye MahiFentaye merged commit b86c73b into feature/samhsa2.0 Jan 24, 2025
7 checks passed
@MahiFentaye MahiFentaye deleted the BFD-3665 branch January 24, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants