BFD-3923: Use versions in child module references #2571
+9
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BFD-3923
What Does This PR Do?
This pins the
bfd-terraservice
module to a known, good version at tagged release 2.181.0 so that we can innovate on the child module for forthcoming fargate and greenfield migrations, without any concerns toward introducing errors.What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
base
,common
,eft
and so on are root modules, while thebfd-terraservice
module is a child module. This PR seeks to reference thatbfd-terraservice
by a tag reference.What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependencies
Modifies any security controls
Adds new transmission or storage of data
Any other changes that could possibly affect security?
I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (
@sb-benohe
) approval.)I have created tests to sufficiently ensure the reliability of my code, if applicable. If this is a modification to an existing piece of code, I have audited the associated tests to ensure everything works as expected.
Validation
Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.
This no-op change was evaluated against all terraservices in
test
–executing e.g.terraform init && terraform apply
didn't yield any meaningful diffs.