[DPC-4442] Remove Endpoint #2396
Conversation
| @@ -170,9 +163,9 @@ private Map<String, Reference> seedPatientBundle(FHIREntityConverter converter, | |||
| }) | |||
| .map(entity -> patientEntityToRecord(context, entity)) | |||
| .peek(context::executeInsert) | |||
| .forEach(record -> { | |||
There was a problem hiding this comment.
"record" is a protected term
|
Have we made sure the web and admin still work? |
| </changeSet> | ||
|
|
||
| <changeSet id="drop-organization-endpoints-table" author="ashley-weaver"> | ||
| <dropTable tableName="ORGANIZATION_ENDPOINTS"/> |
There was a problem hiding this comment.
Do we want to test this migration in a deployed environment before merging or do you have a high level of confidence making these changes? @ashley-weaver
There was a problem hiding this comment.
I agree that cleaning up the databases as a separate ticket is probably safer.
src/main/resources/webster.tmpl.json
Outdated
There was a problem hiding this comment.
do we even use this file anywhere? can it be removed?
There was a problem hiding this comment.
Looks like junk to me. It was added as part of a token validation, but doesn't seem to be used anywhere. grep didn't find it.
| <div class="ds-u-margin-bottom--1"> | ||
| Status: <%= @organization.registered_organization.fhir_endpoint.status.titleize %> | ||
| </div> | ||
|
|
||
| <%= link_to "Edit", edit_organization_registered_organization_path( |
There was a problem hiding this comment.
This should probably go, as the only editing is on the endpoint.
| @@ -0,0 +1,12 @@ | |||
| class DropFhirEndpointsTable < ActiveRecord::Migration[7.2] | |||
There was a problem hiding this comment.
I am kind of thinking we should leave this in case we need to roll back.
dpc-attribution/src/main/java/gov/cms/dpc/attribution/cli/SeedCommand.java
Outdated
Show resolved
Hide resolved
dpc-common/src/test/java/gov/cms/dpc/common/entities/OrganizationEntityTest.java
Outdated
Show resolved
Hide resolved
🎫 Ticket
https://jira.cms.gov/browse/DPC-4442
🛠 Changes
EndpointResource and all associated code removed.
ℹ️ Context
Organization endpoints are not being used, and can be removed.
🧪 Validation
Tests updated.