Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPC-4475 cleanup jacoco #2401

Merged
merged 9 commits into from
Feb 6, 2025
Merged

DPC-4475 cleanup jacoco #2401

merged 9 commits into from
Feb 6, 2025

Conversation

jdettmannnava
Copy link
Contributor

@jdettmannnava jdettmannnava commented Jan 29, 2025

🎫 Ticket

https://jira.cms.gov/browse/DPC-4475

🛠 Changes

dpc-test.sh removes jacocoReport directory if it is present

ℹ️ Context

Currently, if make ci-app fails mid-run, JaCoCo will cause the next run to fail unpredictably, unless the generated
./jacocoReport directroy is manually deleted. So this automatically removes it.

🧪 Validation

Ran make ci-app and jacocoReport directory disappeared; still ran normally.

@jdettmannnava jdettmannnava marked this pull request as ready for review January 31, 2025 19:27
Copy link
Contributor

@ashley-weaver ashley-weaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@jdettmannnava jdettmannnava merged commit cbbcb58 into main Feb 6, 2025
8 checks passed
@jdettmannnava jdettmannnava deleted the jd/dpc-4475-cleanup-jacoco branch February 6, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants