Changing mandatory configuration files parsing method #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary This issue mentions incorrect parsing of the mandatory conf files. if there are files with similar names all would be parsed. this is a fix for it. Details An example of erroneous parsing: VSOMEIP_MANDATORY_CONFIGURATION_FILES=service.json,common.json then only service.json and common.json should be read and parsed. Currently if there are the following files in the configuration folder: main_service.json other_service.json service.json All are parsed. Changing the comparison method for incoming config files fixes it.
duartenfonseca
force-pushed
the
changing_mandatory_path
branch
from
827c69a to
8a16378
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This issue mentions incorrect parsing of the mandatory conf files. if there are files with similar names all would be parsed. this is a fix for it. Details
An example of erroneous parsing:
VSOMEIP_MANDATORY_CONFIGURATION_FILES=service.json,common.json then only service.json and common.json should be read and parsed. Currently if there are the following files in the configuration folder: main_service.json
other_service.json
service.json
All are parsed. Changing the comparison method for incoming config files fixes it.
Fixes issue #243