Batch of PR's for vsomeip 3.5.5 #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary Clear requests_to_debounce_ on release_service Details Without the missing break the while (it != requests_to_debounce_.end()) will loop until the end of the collection and the following verification if (it != requests_to_debounce_.end()) requests_to_debounce_.erase(it); will never run.
Summary reset force_initial_events Details force_initial_events wasn't being reseted
Summary Reintroduce VSOMEIP_CONFIG to wireshark plugin. Details It was removed by mistake
Summary Enable partial valgrind subprocess tracking Details It has been discovered that valgrind only ran properly on tests that were executed without the assistance of a script (client_id_utility_tests). After some analysis, it has been identified that valgrind only tracks the main process and will monitor the subprocesses only if instructed to do so. This PR enables the --trace-children valgrind option to instruct the profiler to track subprocesses, as this increased significantly the number of memcheck and helgrind erros, it has been decided to do a test by test parameterization i.e., add the possibility to "disable" subprocess tracking for some tests via the CMAKE option TEST_SKIP_VALGRIND_TRACKING. The skip shall be removed tests by tests when they'll be fixed. Moreover, boost artifacts are now build from sources to add valgrind support.
duartenfonseca
changed the title
Summary Ensure endpoint is not deleted during send operations by binding the shared pointer to the lambda that is called when the operation returns.
Summary Avoid hanging request service commands Details routing_manager_client::request_service uses a debounce mechanism to collect multiple service requests and send them in a single command. The current implementation contains a race condition that can result in service requests not being sent to the routing manager until the next service request is done. This is, if resetting the flag within the timer callback and a call to request_service run in parallel, as the flag and the set are protected by two different mutexes. This PR tries to fix this by retiring one of the mutexes and using the other one to protect the set as well as the timer and its flag.
Summary This pseudo-reverts a change introduced in ade0d62 that caused the host to close client connections before completing the deregistration process.
Summary Add mutex to protect registration state on request, regist, offer, unregister, release and stop offer Wait for registration to complete before attempting to regist/request/offer/unregister/release/stop offer Ensure state value before send_pending_commands Details Waits for registration to be acknowledged before start to regist/request/offer/unregister/release/stop offer
Summary Clean-up service info on client registration. Details These changes fix an issue related to Suspend-To-RAM (STR) where a failure to de-register the application during suspend prevent it from offering a service when it tried to re-register. This is because the routing manager still kept some information from the previous lifecycle, which caused it to ignore the new information. The fix involves cleaning-up the local service info of the routing manager every time that a client tries to register.
duartenfonseca
force-pushed
the
batch_for_3_5_5
branch
from
1bfb852 to
572ace7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.