Serrano #11
Merged
Serrano #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camiloserr
requested review from
ayurojasn and
mateoflorido
and removed request for
ayurojasn and
mateoflorido
ayurojasn
reviewed
Apr 30, 2021
There was a problem hiding this comment.
- Cambiarle el tamaño a la ilustración de la parte derecha (un poco más grande).
- Agregarle COP al final de la cantidad de dinero en la parte derecha.
- Achiquitar Community Service by ACM Javeriana del header, igual con el logo y agregarle margen izq y der para que se alineen con la línea de división del footer.
- Arreglar footer para que no tape el contenido cuando la pantalla es más pequeña.
ayurojasn
reviewed
Apr 30, 2021
mateoflorido
reviewed
May 1, 2021
mateoflorido
approved these changes
May 2, 2021
Comment on lines
+27
to
+28
| <mat-option (click)="changeCurrency('COP')" >COP</mat-option> | ||
| <mat-option (click)="changeCurrency('USD')" >USD</mat-option> |
There was a problem hiding this comment.
Podríamos utilizar el Currency Service en un futuro para insertar las diferentes monedas.
There was a problem hiding this comment.
De acuerdo, si eso llega a pasar solo tocaria pedir todos los cambios de moneda de dolares a X en onInit y agregar los cambios de moneda en el método changeCurrency en main.components.ts
ayurojasn
approved these changes
May 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added illustration for right pane.
Created service to read cause from json file
Select is using objects read from file
Money slider updates when user selects a cause
People slider updates when user selects a community
Closes #3
Closes #5