Fix a bug with instances that have multiple nodes #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The i3dm converter was repeatedly overwriting the beginning of the new glTF buffer that holds instance transformations.
The version of MSVC on github MSVC 19.41.34120.0 seems to be more picky.
|
Looks good, thanks @timoore! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The i3dm converter was repeatedly overwriting the beginning of the new glTF buffer that holds instance transformations.
Resolves #942
I would like to add a test case for this and am hoping that the user who reported the issue will give their permission to use their test data.