build xcode project as part of the build process

CesiumGS · Sep 4, 2023 · 57217df · 57217df
1 parent 878245e
commit 57217df
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,5 +1,11 @@
 # Change Log
 
+### ? - ?
+
+##### Fixes :wrench:
+
+- Build the XCode project and verify it for errors during the iOS building proces. This ensures the iOS plugin from CI has all the required libraries.
+
 ### v1.6.1 - 2023-09-03
 
 ##### Fixes :wrench:

diff --git a/Editor/BuildCesiumForUnity.cs b/Editor/BuildCesiumForUnity.cs
@@ -66,10 +66,18 @@ public static void CompileForIOSAndExit()
             Directory.CreateDirectory(buildPath);
             try
             {
-                BuildPlayer(BuildTargetGroup.iOS, BuildTarget.iOS, Path.Combine(buildPath, "iOS"));
+                BuildPlayer(BuildTargetGroup.iOS, BuildTarget.iOS, Path.Combine(buildPath, "iOS"), false);
+                // Check that XCode project is able to build
+                System.Diagnostics.Process p = System.Diagnostics.Process.Start("xcodebuild",
+                  $"-project {Path.Combine(buildPath, "iOS/game/Unity-iPhone.xcodeproj")} CODE_SIGNING_ALLOWED=NO");
+                p.WaitForExit();
+                if (p.ExitCode != 0)
+                    throw new Exception("xcodebuild failed");
             }
             finally
             {
+                if (Directory.Exists(Path.Combine(buildPath, "iOS")))
+                    Directory.Delete(Path.Combine(buildPath, "iOS"), true);
                 Directory.Delete(buildPath, true);
             }
             EditorApplication.Exit(0);
@@ -130,7 +138,7 @@ public static void PackAndExit()
             };
         }
 
-        private static void BuildPlayer(BuildTargetGroup targetGroup, BuildTarget target, string outputPath)
+        private static void BuildPlayer(BuildTargetGroup targetGroup, BuildTarget target, string outputPath, bool deleteProject = true)
         {
             BuildReport report = BuildPipeline.BuildPlayer(new BuildPlayerOptions()
             {
@@ -161,7 +169,7 @@ private static void BuildPlayer(BuildTargetGroup targetGroup, BuildTarget target
             }
 
             // We don't actually need the built project; delete it.
-            if (Directory.Exists(outputPath))
+            if (deleteProject && Directory.Exists(outputPath))
                 Directory.Delete(outputPath, true);
         }
     }