Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move custom shaders guide into the Documentation directory #10054

Merged
merged 4 commits into from
Jan 31, 2022

Conversation

ptrgags
Copy link
Contributor

@ptrgags ptrgags commented Jan 31, 2022

Custom Shaders does have documentation, it just was hiding in the ModelExperimental folder while under development. I'm moving it to a more discoverable place, in Documentation/Contributors/CustomShaderGuide/README.md.

@ggetz I'm not 100% certain if this is the right subfolder. If there's a better place to put it, please let me know and I'll update this PR.

@ptrgags ptrgags requested a review from ggetz January 31, 2022 16:29
@cesium-concierge
Copy link

Thanks for the pull request @ptrgags!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@ggetz
Copy link
Contributor

ggetz commented Jan 31, 2022

I agree that its a bit out of place to put this in Documentation/Contributors. To be consistent with the only other non-contributor documentation, the fabric schema, I think this should live in Documentation directly, so maybe Documentation/CustomShaderGuide/README.md?

@ptrgags
Copy link
Contributor Author

ptrgags commented Jan 31, 2022

@ggetz updated! I also added a changelog entry

@ggetz
Copy link
Contributor

ggetz commented Jan 31, 2022

Thanks @ptrgags! So this guide's content has been previously reviewed, correct?

@ptrgags
Copy link
Contributor Author

ptrgags commented Jan 31, 2022

@ggetz yes, this guide was reviewed when Custom Shaders was originally added, and again recently in #10018

@ggetz ggetz merged commit 80fa50e into main Jan 31, 2022
@ggetz ggetz deleted the move-custom-shaders-guide branch January 31, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants