Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Billboard clamping #12482

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Billboard clamping #12482

wants to merge 7 commits into from

Conversation

CodyBu
Copy link

@CodyBu CodyBu commented Feb 18, 2025

Description

Updates scene getHeight function to recursively check for nested primitives within primitive collection when getting scene height

Issue number and link

Issue #12454

Testing plan

Adds test which will add 2 tilesets to a PrimitiveCollection and adds that collection to a scene, then checks the scene height to make sure it is the max of the 2 tilesets.

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

Copy link

Thank you for the pull request, @CodyBu!

✅ We can confirm we have a CLA on file for you.

@ggetz
Copy link
Contributor

ggetz commented Feb 20, 2025

Thanks for the fix @CodyBu! I took a pass over the code, and the approach here looks good to me!

Please add an item to CHANGES.md describing the fix.

@jjspace Could you please do a testing pass on this PR to sanity check that performance wasn't affected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants