Fix ground atmosphere shaders in 3D orthographic mode #12484
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
3D orthographic mode is currently broken with the default globe options (i.e.,
showGroundAtmosphere = true
-- see the Projection sandcastle). The behavior can be fixed by settingshowGroundAtmosphere = false
. See the attached videos:Before (showGroundAtmosphere = true)
CleanShot.2025-02-19.at.11.26.20.mp4
Before (showGroundAtmosphere = false)
CleanShot.2025-02-19.at.11.28.42.mp4
This pull request fixes the ground atmosphere shaders so that 3D orthographic mode works by default. See the attached video of this fix, with
showGroundAtmosphere = true
:CleanShot.2025-02-19.at.11.28.11.mp4
Issue number and link
#11955
Testing plan
Manual testing with the Projection sandcastle, or with the following code:
Author checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change