-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store feature tables and feature textures as arrays to support EXT_mesh_features
#9872
Conversation
Thanks for the pull request @ptrgags!
Reviewers, don't forget to make sure that:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ptrgags I have done a first pass over the code. Have not looked at the tests yet.
@sanjeetsuhag updated! |
@sanjeetsuhag just synced with |
Changes look good to me. Models are loading fine and picking works for both old and new extension. @lilleyse Would you like to take a look before I merge? |
@lilleyse at this point I've addressed your feedback, though I still have to go through and check test coverage to see what tests to add. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverage is pretty good, just a few places that need improvement
Looks good! |
Recently we've been revising
EXT_feature_metadata
. This has resulted in a newer draft of the schema,EXT_mesh_features
.One of the biggest changes is that metadata textures and tables are now defined with an array instead of a dictionary. This PR updates
GltfLoader
to handle this array-based storage.This adds most support for
EXT_mesh_features
, however, I have not yet handled the differences in data type schema, I'll do that as a separate PR since this was already a ~2000 line change.I also updated 3 of the test datasets (weather, microcosm, and box instanced) to use the new extension.
@sanjeetsuhag could you review?
CC: @lilleyse