-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select linters & project logo. #9
Conversation
There is no need to breed entities. I thought that would be one - two config files with configs for pylint and pydocstyle. Github actions is pretty good, by the way! |
* Solve TODO. Add link to the issue of 'Task-Reaction system'. (cherry picked from commit 80d04f7)
Please, review the request. Also fix github action so before using pylama it will patch the package. |
I will add documentation to the README about our linters, so, please, review it and do not merge, until I fix README. |
Ok, we decided to use |
Ok, we finally decided to use |
Now to run checkers you should use:
Currently now they do not throw any erros. P.S. Of cource, I added these instructions to the README. |
* We will save our tests in `tests` folder.
.github/workflows/push_to_master.yml
Outdated
- name: Set up Python 3.8 | ||
uses: actions/setup-python@v2 | ||
with: | ||
python-version: 3.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It think we should use last 3.10 version of python
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It think we should use last 3.10 version of python
Last version is cool, but there are people, who do not follow last news. So, they have, for example 3.6 version, but some new features in 3.10 will not work in 3.6. That is why these people will not upgrade the python on their machines just for one package. I'm sure we should use not laster version than 3.8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seams strange for me to use older python, because most servers use 3.6. Because project development on older python partially forces users not to update they're python. Also many client machines run 3.8 now, because recent distros support it.
Solve https://github.com/KH9IZ/task_tree_local/issues/7
Add steps to run linters on your repo local copy.