Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump ws and ethers #2034

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 3, 2025

Bumps ws to 8.17.1 and updates ancestor dependencies ws and ethers. These dependencies need to be updated together.

Updates ws from 8.5.0 to 8.17.1

Release notes

Sourced from ws's releases.

8.17.1

Bug fixes

  • Fixed a DoS vulnerability (#2231).

A request with a number of headers exceeding the[server.maxHeadersCount][] threshold could be used to crash a ws server.

const http = require('http');
const WebSocket = require('ws');
const wss = new WebSocket.Server({ port: 0 }, function () {
const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
const headers = {};
let count = 0;
for (let i = 0; i < chars.length; i++) {
if (count === 2000) break;
for (let j = 0; j &lt; chars.length; j++) {
  const key = chars[i] + chars[j];
  headers[key] = 'x';
if (++count === 2000) break;
}

}
headers.Connection = 'Upgrade';
headers.Upgrade = 'websocket';
headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
headers['Sec-WebSocket-Version'] = '13';
const request = http.request({
headers: headers,
host: '127.0.0.1',
port: wss.address().port
});
request.end();
});

The vulnerability was reported by Ryan LaPointe in websockets/ws#2230.

In vulnerable versions of ws, the issue can be mitigated in the following ways:

  1. Reduce the maximum allowed length of the request headers using the [--max-http-header-size=size][] and/or the [maxHeaderSize][] options so that no more headers than the server.maxHeadersCount limit can be sent.

... (truncated)

Commits
  • 3c56601 [dist] 8.17.1
  • e55e510 [security] Fix crash when the Upgrade header cannot be read (#2231)
  • 6a00029 [test] Increase code coverage
  • ddfe4a8 [perf] Reduce the amount of crypto.randomFillSync() calls
  • b73b118 [dist] 8.17.0
  • 29694a5 [test] Use the highWaterMark variable
  • 934c9d6 [ci] Test on node 22
  • 1817bac [ci] Do not test on node 21
  • 96c9b3d [major] Flip the default value of allowSynchronousEvents (#2221)
  • e5f32c7 [fix] Emit at most one event per event loop iteration (#2218)
  • Additional commits viewable in compare view

Updates ethers from 6.13.0 to 6.13.5

Release notes

Sourced from ethers's releases.

ethers/v6.13.5 (2025-01-04 15:26)

  • Use local dev net for testing Typed API to prevent tests getting throttled (7654ee3).
  • Fixed bad logic for searching prefetched transactions by hash (#4868; ef3c9bc).
  • Add newline delimiter to IPC providers for broader support (#4847; 474a8de).

ethers/v6.13.4 (2024-10-10 18:01)

ethers/v6.13.3 (2024-09-30 22:08)

  • Allow CCIP-read to continue during low-level fetch failures (#4842; 1c31f95).

ethers/v6.13.2 (2024-07-25 18:20)

  • Prevent mutating transactions when signing (#4789; 1a51af8).

ethers/v6.13.1 (2024-06-18 02:37)

  • Update ws package to address possible DoS vulnerability (a4b1d1f).
Changelog

Sourced from ethers's changelog.

ethers/v6.13.5 (2025-01-04 15:26)

  • Use local dev net for testing Typed API to prevent tests getting throttled (7654ee3).
  • Fixed bad logic for searching prefetched transactions by hash (#4868; ef3c9bc).
  • Add newline delimiter to IPC providers for broader support (#4847; 474a8de).

ethers/v6.13.4 (2024-10-10 18:01)

ethers/v6.13.3 (2024-09-30 22:08)

  • Allow CCIP-read to continue during low-level fetch failures (#4842; 1c31f95).

ethers/v6.13.2 (2024-07-25 17:54)

  • Prevent mutating transactions when signing (#4789; 1a51af8).

ethers/v6.13.1 (2024-06-18 02:09)

  • Update ws package to address possible DoS vulnerability (a4b1d1f).
Commits
  • ce7212d tests: debugging CI browser failure
  • f1821a6 tests: debugging CI browser failure
  • cc9119c tests: debugging CI browser failure
  • 3ac33f9 tests: debugging CI browser failure
  • 25b11ee tests: debugging CI browser failure
  • 3bcbcae tests: debug CI failing
  • 27eb944 admin: updated dist files
  • 3854b39 tests: added circular support to browser-safe inspect
  • 831b21d admin: updated dist files
  • e299a31 tests: added browser-safe inspect for tests
  • Additional commits viewable in compare view

Updates ethers from 5.7.2 to 6.13.5

Release notes

Sourced from ethers's releases.

ethers/v6.13.5 (2025-01-04 15:26)

  • Use local dev net for testing Typed API to prevent tests getting throttled (7654ee3).
  • Fixed bad logic for searching prefetched transactions by hash (#4868; ef3c9bc).
  • Add newline delimiter to IPC providers for broader support (#4847; 474a8de).

ethers/v6.13.4 (2024-10-10 18:01)

ethers/v6.13.3 (2024-09-30 22:08)

  • Allow CCIP-read to continue during low-level fetch failures (#4842; 1c31f95).

ethers/v6.13.2 (2024-07-25 18:20)

  • Prevent mutating transactions when signing (#4789; 1a51af8).

ethers/v6.13.1 (2024-06-18 02:37)

  • Update ws package to address possible DoS vulnerability (a4b1d1f).
Changelog

Sourced from ethers's changelog.

ethers/v6.13.5 (2025-01-04 15:26)

  • Use local dev net for testing Typed API to prevent tests getting throttled (7654ee3).
  • Fixed bad logic for searching prefetched transactions by hash (#4868; ef3c9bc).
  • Add newline delimiter to IPC providers for broader support (#4847; 474a8de).

ethers/v6.13.4 (2024-10-10 18:01)

ethers/v6.13.3 (2024-09-30 22:08)

  • Allow CCIP-read to continue during low-level fetch failures (#4842; 1c31f95).

ethers/v6.13.2 (2024-07-25 17:54)

  • Prevent mutating transactions when signing (#4789; 1a51af8).

ethers/v6.13.1 (2024-06-18 02:09)

  • Update ws package to address possible DoS vulnerability (a4b1d1f).
Commits
  • ce7212d tests: debugging CI browser failure
  • f1821a6 tests: debugging CI browser failure
  • cc9119c tests: debugging CI browser failure
  • 3ac33f9 tests: debugging CI browser failure
  • 25b11ee tests: debugging CI browser failure
  • 3bcbcae tests: debug CI failing
  • 27eb944 admin: updated dist files
  • 3854b39 tests: added circular support to browser-safe inspect
  • 831b21d admin: updated dist files
  • e299a31 tests: added browser-safe inspect for tests
  • Additional commits viewable in compare view

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
ethers [>= 6.a, < 7]

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [ws](https://github.com/websockets/ws) to 8.17.1 and updates ancestor dependencies [ws](https://github.com/websockets/ws) and [ethers](https://github.com/ethers-io/ethers.js). These dependencies need to be updated together.


Updates `ws` from 8.5.0 to 8.17.1
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@8.5.0...8.17.1)

Updates `ethers` from 6.13.0 to 6.13.5
- [Release notes](https://github.com/ethers-io/ethers.js/releases)
- [Changelog](https://github.com/ethers-io/ethers.js/blob/main/CHANGELOG.md)
- [Commits](ethers-io/ethers.js@v6.13.0...v6.13.5)

Updates `ethers` from 5.7.2 to 6.13.5
- [Release notes](https://github.com/ethers-io/ethers.js/releases)
- [Changelog](https://github.com/ethers-io/ethers.js/blob/main/CHANGELOG.md)
- [Commits](ethers-io/ethers.js@v6.13.0...v6.13.5)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
- dependency-name: ethers
  dependency-type: direct:production
- dependency-name: ethers
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Feb 3, 2025
@dependabot dependabot bot requested review from bajtos and juliangruber February 3, 2025 02:20
@github-actions github-actions bot enabled auto-merge (squash) February 3, 2025 02:21
Copy link

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] 🔁 npm/[email protected], npm/[email protected] None +5 17.5 MB ricmoo

View full report↗︎

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 3, 2025

Looks like these dependencies are no longer a dependency, so this is no longer needed.

@dependabot dependabot bot closed this Feb 3, 2025
auto-merge was automatically disabled February 3, 2025 02:40

Pull request was closed

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/multi-9a1d7ab571 branch February 3, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants