Clean SortInput postfix #8045
Open
Clean SortInput postfix #8045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8045 +/- ##
==========================================
- Coverage 73.85% 73.85% -0.01%
==========================================
Files 2645 2645
Lines 138630 138645 +15
Branches 16056 16059 +3
==========================================
+ Hits 102391 102398 +7
- Misses 30775 30781 +6
- Partials 5464 5466 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
glen-84
requested changes
Feb 21, 2025
src/HotChocolate/Data/src/Data/Sorting/Convention/SortConvention.cs
Outdated
Show resolved
Hide resolved
src/HotChocolate/Data/test/Data.Sorting.Tests/SortInputTypeTests.cs
Outdated
Show resolved
Hide resolved
src/HotChocolate/Data/test/Data.Sorting.Tests/SortInputTypeTests.cs
Outdated
Show resolved
Hide resolved
|
I've moved the test to |
glen-84
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to align FilterInput naming convention handling