Add support for relative cursors. #8048
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelstaib
commented
Feb 20, 2025
| } | ||
| } | ||
|
|
||
| public record Cursor( |
There was a problem hiding this comment.
Move out these two types.
michaelstaib
commented
Feb 20, 2025
| /// <summary> | ||
| /// Gets the index number of this page. | ||
| /// </summary> | ||
| public int? Index => _index; |
There was a problem hiding this comment.
Not sure about the name of this yet.
michaelstaib
commented
Feb 20, 2025
| @@ -72,7 +132,17 @@ public sealed class Page<T>( | |||
| /// <returns> | |||
| /// Returns a cursor for the item. | |||
| /// </returns> | |||
| public string CreateCursor(T item) => createCursor(item); | |||
| public string CreateCursor(T item) => _createCursor(item, 0, 0, 0); | |||
There was a problem hiding this comment.
Should we remove this? Like instead have an extension method for the cursors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.