Update xcode color mapping #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change makes the insertionPoint property optional to better handle themes where this value might not be present, falling back to default values when not specified.
The test was comparing Color objects directly, which can be unreliable. Instead, compare the hex string representations of the colors for more stable equality checks.
The changes improve organization of syntax highlighting rules by grouping related styles together and fixing a typo in the macro identifier key. It also separates constructor/property definitions to use a more appropriate declaration style.
|
These are always hard to get right, but looks great. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these are more accurate mappings of the Xcode -> ThemePark style. Although it still may not be perfect.