Skip to content

Commit

Permalink
Move owners files into config/owners
Browse files Browse the repository at this point in the history
The separate *_OWNERS files are related and can be grouped together
in a folder to make this distinction clear. This will allow us
to update the PRESUBMIT script to explicitly mark them as
exclusive change directory.

Note that the directory is named "owner", as we can't name it
"owners" as that is case-insensitive equivalent to "OWNERS",
which Windows can't handle in its presubmits.

DISABLE_THIRD_PARTY_CHECK=OWNERS update
[email protected]

Bug: 1187573
Change-Id: Ib94a544c9dc01f788a8b75a5c8111ab52fbc27b8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2814658
Commit-Queue: Tim van der Lippe <[email protected]>
Commit-Queue: Yang Guo <[email protected]>
Auto-Submit: Tim van der Lippe <[email protected]>
Reviewed-by: Yang Guo <[email protected]>
  • Loading branch information
TimvdLippe authored and Commit Bot committed Apr 8, 2021
1 parent 2506df7 commit 2e14387
Show file tree
Hide file tree
Showing 28 changed files with 49 additions and 49 deletions.
42 changes: 21 additions & 21 deletions OWNERS
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
file://ENG_REVIEW_OWNERS
file://config/owner/ENG_REVIEW_OWNERS

per-file .*=file://INFRA_OWNERS
per-file AUTHORS=file://COMMON_OWNERS
per-file BUILD.gn=file://INFRA_OWNERS
per-file DEPS=file://INFRA_OWNERS
per-file PRESUBMIT.py=file://INFRA_OWNERS
per-file ARCHITECTURE.md=file://INFRA_OWNERS
per-file README.md=file://COMMON_OWNERS
per-file WATCHLISTS=file://INFRA_OWNERS
per-file all_devtools_files.gni=file://COMMON_OWNERS
per-file all_devtools_modules.gni=file://COMMON_OWNERS
per-file devtools_grd_files.gni=file://COMMON_OWNERS
per-file codereview.settings=file://INFRA_OWNERS
per-file devtools_image_files.gni=file://COMMON_OWNERS
per-file devtools_module_entrypoints.gni=file://COMMON_OWNERS
per-file htaccess=file://INFRA_OWNERS
per-file karma.conf.json=file://INFRA_OWNERS
per-file package-lock.json=file://INFRA_OWNERS
per-file package.json=file://INFRA_OWNERS
per-file tsconfig.base.json=file://INFRA_OWNERS
per-file tsconfig.json=file://INFRA_OWNERS
per-file .*=file://config/owner/INFRA_OWNERS
per-file AUTHORS=file://config/owner/COMMON_OWNERS
per-file BUILD.gn=file://config/owner/INFRA_OWNERS
per-file DEPS=file://config/owner/INFRA_OWNERS
per-file PRESUBMIT.py=file://config/owner/INFRA_OWNERS
per-file ARCHITECTURE.md=file://config/owner/INFRA_OWNERS
per-file README.md=file://config/owner/COMMON_OWNERS
per-file WATCHLISTS=file://config/owner/INFRA_OWNERS
per-file all_devtools_files.gni=file://config/owner/COMMON_OWNERS
per-file all_devtools_modules.gni=file://config/owner/COMMON_OWNERS
per-file devtools_grd_files.gni=file://config/owner/COMMON_OWNERS
per-file codereview.settings=file://config/owner/INFRA_OWNERS
per-file devtools_image_files.gni=file://config/owner/COMMON_OWNERS
per-file devtools_module_entrypoints.gni=file://config/owner/COMMON_OWNERS
per-file htaccess=file://config/owner/INFRA_OWNERS
per-file karma.conf.json=file://config/owner/INFRA_OWNERS
per-file package-lock.json=file://config/owner/INFRA_OWNERS
per-file package.json=file://config/owner/INFRA_OWNERS
per-file tsconfig.base.json=file://config/owner/INFRA_OWNERS
per-file tsconfig.json=file://config/owner/INFRA_OWNERS
2 changes: 1 addition & 1 deletion PRESUBMIT.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
EXCLUSIVE_CHANGE_DIRECTORIES = [
['third_party', 'v8'],
['node_modules'],
['OWNERS'],
['OWNERS', 'config/owner'],
]

AUTOROLL_ACCOUNT = "devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com"
Expand Down
2 changes: 1 addition & 1 deletion build_overrides/OWNERS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
file://INFRA_OWNERS
file://config/owner/INFRA_OWNERS
2 changes: 1 addition & 1 deletion COMMON_OWNERS → config/owner/COMMON_OWNERS
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
file://ENG_REVIEW_OWNERS
file://config/owner/ENG_REVIEW_OWNERS

[email protected]
[email protected]
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion docs/OWNERS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
file://COMMON_OWNERS
file://config/owner/COMMON_OWNERS
2 changes: 1 addition & 1 deletion front_end/Images/OWNERS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
file://COMMON_OWNERS
file://config/owner/COMMON_OWNERS
6 changes: 3 additions & 3 deletions front_end/OWNERS
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
file://INFRA_OWNERS
per-file *_test_runner=file://COMMON_OWNERS
per-file audits*=file://LIGHTHOUSE_OWNERS
file://config/owner/INFRA_OWNERS
per-file *_test_runner=file://config/owner/COMMON_OWNERS
per-file audits*=file://config/owner/LIGHTHOUSE_OWNERS

[email protected]
2 changes: 1 addition & 1 deletion front_end/components/OWNERS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
file://COMMON_OWNERS
file://config/owner/COMMON_OWNERS
2 changes: 1 addition & 1 deletion front_end/core/common/OWNERS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
file://COMMON_OWNERS
file://config/owner/COMMON_OWNERS
2 changes: 1 addition & 1 deletion front_end/core/i18n/locales/OWNERS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
file://COMMON_OWNERS
file://config/owner/COMMON_OWNERS
2 changes: 1 addition & 1 deletion front_end/generated/OWNERS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
file://COMMON_OWNERS
file://config/owner/COMMON_OWNERS
2 changes: 1 addition & 1 deletion front_end/legacy_test_runner/lighthouse_test_runner/OWNERS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
file://LIGHTHOUSE_OWNERS
file://config/owner/LIGHTHOUSE_OWNERS
2 changes: 1 addition & 1 deletion front_end/lighthouse_worker/OWNERS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
file://LIGHTHOUSE_OWNERS
file://config/owner/LIGHTHOUSE_OWNERS
2 changes: 1 addition & 1 deletion front_end/panels/help/OWNERS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
file://COMMON_OWNERS
file://config/owner/COMMON_OWNERS
4 changes: 2 additions & 2 deletions front_end/panels/lighthouse/OWNERS
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
file://LIGHTHOUSE_OWNERS
file://INFRA_OWNERS
file://config/owner/LIGHTHOUSE_OWNERS
file://config/owner/INFRA_OWNERS
2 changes: 1 addition & 1 deletion front_end/third_party/OWNERS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
file://INFRA_OWNERS
file://config/owner/INFRA_OWNERS
2 changes: 1 addition & 1 deletion front_end/third_party/axe-core/OWNERS
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
file://COMMON_OWNERS
file://config/owner/COMMON_OWNERS
[email protected]
[email protected]
4 changes: 2 additions & 2 deletions front_end/third_party/lighthouse/OWNERS
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
file://LIGHTHOUSE_OWNERS
file://INFRA_OWNERS
file://config/owner/LIGHTHOUSE_OWNERS
file://config/owner/INFRA_OWNERS
2 changes: 1 addition & 1 deletion scripts/OWNERS
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
file://INFRA_OWNERS
file://config/owner/INFRA_OWNERS

[email protected]
2 changes: 1 addition & 1 deletion scripts/deps/manage_node_deps.py
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ def addOwnersFile():
with open(path.join(devtools_paths.node_modules_path(), 'OWNERS'),
'w+') as owners_file:
try:
owners_file.write('file://INFRA_OWNERS\n')
owners_file.write('file://config/owner/INFRA_OWNERS\n')
except:
print('Unable to write OWNERS file')
return True
Expand Down
2 changes: 1 addition & 1 deletion test/OWNERS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
file://COMMON_OWNERS
file://config/owner/COMMON_OWNERS
2 changes: 1 addition & 1 deletion test/webtests/http/tests/devtools/lighthouse/OWNERS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
file://LIGHTHOUSE_OWNERS
file://config/owner/LIGHTHOUSE_OWNERS
2 changes: 1 addition & 1 deletion third_party/OWNERS
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
file://INFRA_OWNERS
file://config/owner/INFRA_OWNERS

2 changes: 1 addition & 1 deletion third_party/blink/OWNERS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
file://COMMON_OWNERS
file://config/owner/COMMON_OWNERS
2 changes: 1 addition & 1 deletion v8/OWNERS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
file://COMMON_OWNERS
file://config/owner/COMMON_OWNERS

0 comments on commit 2e14387

Please sign in to comment.