Merge pull request #45 from ClarkSource/#42

[#42] replace own file edit command with clicks
ClarkSource · Feb 7, 2020 · bd3d41a · bd3d41a
2 parents 4e5b204 + 39af02a
commit bd3d41a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -122,7 +122,8 @@ $ k8t new template deployment -c MyCluster -e staging
 
 ### Config management
 
-To ease file access a little bit k8t can open config and value files in your `$EDITOR` with a fallback to `vim`
+To ease file access a little bit k8t can open config and value files in your `$EDITOR` or fallback to a sensible
+default.
 
 ```bash
 $ k8t edit values --environment staging

diff --git a/k8t/cli.py b/k8t/cli.py
@@ -271,7 +271,7 @@ def edit_config(directory, cname, ename):  # pylint: disable=redefined-outer-nam
     else:
         file_path = os.path.join(directory, "config.yaml")
 
-    os.system("%s %s" % (os.getenv("EDITOR", "vim"), file_path))
+    click.edit(filename=file_path)
 
 
 @edit.command(name="values", help="Edit value files in chosen context.")
@@ -286,7 +286,7 @@ def edit_values(directory, cname, ename):  # pylint: disable=redefined-outer-nam
 
     file_path = os.path.join(base_dir, "values.yaml")
 
-    os.system("%s %s" % (os.getenv("EDITOR", "vim"), file_path))
+    click.edit(filename=file_path)
 
 
 def main():