Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a Mode_INP aerosol distribution #279

Closed
wants to merge 11 commits into from
Closed

Adding a Mode_INP aerosol distribution #279

wants to merge 11 commits into from

Conversation

amylu00
Copy link
Member

@amylu00 amylu00 commented Dec 3, 2023

Purpose

  • Add an INP aerosol distribution to eventually have aerosol activation in parcel

To-do

  • unit test
  • performance test
  • gpu test
  • add aerosol activation function(?)

Content


  • I have read and checked the items on the review checklist.

@trontrytel
Copy link
Member

@amylu00 Could you remind me what we were trying to do here? Do we want to use it to store the aerosol size distribution parameters for the parcel simulations? I guess we would need a different type for delta, gamma, etc size distributions?

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (63b15c8) 98.53% compared to head (4f5bce0) 98.32%.
Report is 8 commits behind head on main.

Files Patch % Lines
src/AerosolModel.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
- Coverage   98.53%   98.32%   -0.22%     
==========================================
  Files          32       31       -1     
  Lines         819      834      +15     
==========================================
+ Hits          807      820      +13     
- Misses         12       14       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amylu00 amylu00 closed this Jan 29, 2024
@amylu00 amylu00 deleted the ajal/inp_mode branch October 22, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants