Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combine box and parcel models #481

Merged
merged 1 commit into from
Nov 15, 2024
Merged

combine box and parcel models #481

merged 1 commit into from
Nov 15, 2024

Conversation

amylu00
Copy link
Member

@amylu00 amylu00 commented Nov 14, 2024

Purpose

To-do

Content


  • I have read and checked the items on the review checklist.

@amylu00
Copy link
Member Author

amylu00 commented Nov 14, 2024

Do we want to rename everything? The default will be parcel settings.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.81%. Comparing base (7e030b2) to head (c9e0290).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #481   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files          41       41           
  Lines        1601     1601           
=======================================
  Hits         1534     1534           
  Misses         67       67           
Components Coverage Δ
src 97.47% <ø> (ø)
ext 69.79% <ø> (ø)

@trontrytel
Copy link
Member

I think the docs error is unrelated to the PR... Also, I'm not getting it locally. I'll try to pin the package versions

@trontrytel
Copy link
Member

I changed some names to be more descriptive. Lmk if you like the new names. Looks good otherwise.

Copy link
Member

@trontrytel trontrytel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets see if I can get rid of the docs errors...

@amylu00 amylu00 enabled auto-merge November 15, 2024 06:05
@amylu00 amylu00 merged commit 1f53254 into main Nov 15, 2024
8 checks passed
@amylu00 amylu00 deleted the al/0D_drivers branch November 20, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants