Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloud diagnostics #510

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Add cloud diagnostics #510

merged 1 commit into from
Feb 7, 2025

Conversation

trontrytel
Copy link
Member

This PR:

  • moves the existing 1M and 2M radar reflectivity and effective radius to a CloudDiagnostics module
  • adds a simple constant effective radius function (based on ClimaParams)
  • adds a wrapper for Lu and Hallet effective radius parameterization that assumes N=100 (allows it to be used with 0M and 1M schemes)

@trontrytel trontrytel requested a review from szy21 February 6, 2025 21:20
@trontrytel trontrytel self-assigned this Feb 6, 2025
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't go through any equations but the code change looks good to me.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.60%. Comparing base (174ef92) to head (141ee90).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #510      +/-   ##
==========================================
+ Coverage   95.58%   95.60%   +0.01%     
==========================================
  Files          41       42       +1     
  Lines        1609     1615       +6     
==========================================
+ Hits         1538     1544       +6     
  Misses         71       71              
Components Coverage Δ
src 97.23% <100.00%> (+0.01%) ⬆️
ext 69.79% <ø> (ø)

@trontrytel trontrytel force-pushed the aj/cloud_diagnostics branch from d4523b9 to 33cc783 Compare February 7, 2025 00:19
@trontrytel trontrytel force-pushed the aj/cloud_diagnostics branch from 33cc783 to 141ee90 Compare February 7, 2025 00:48
@trontrytel trontrytel enabled auto-merge February 7, 2025 00:50
@trontrytel trontrytel merged commit 4a37e01 into main Feb 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants