New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace dot imports with normal imports #30

Merged

elfrucool merged 1 commit into main from 29-replace-dot-imports-with-normal-imports

Feb 5, 2025

Collaborator

elfrucool commented Feb 4, 2025

There were several dot imports from internal/smb2 to root package, that will cause problems in long term and it is considered a bad practice

This commit replaces them with normal imports


          Replace dot imports with normal imports

3eb3885

elfrucool linked an issue

that may be closed by this pull request

Replace dot imports with normal imports #29

Closed

Collaborator

arashpayan commented Feb 5, 2025

Looks good. Bring it in.

elfrucool merged commit 2fd990c into main

2 checks passed

elfrucool deleted the 29-replace-dot-imports-with-normal-imports branch

February 5, 2025 19:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet