Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image links #261

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Update image links #261

merged 3 commits into from
Mar 27, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 2, 2024

Update all picURLs in the tokens.xml file via Scryfall API.


This PR is automatically generated and updated by the workflow at .github/workflows/update_links.yml. Review action runs.

Copy link
Contributor

@tooomm tooomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resulting PR of the script run looks fine.

@tooomm
Copy link
Contributor

tooomm commented Mar 2, 2024

Not sure why the PR doesn't trigger an image link check here:
https://github.com/Cockatrice/Magic-Token/blob/master/.github/workflows/check_links.yml#L9-L13


Edit: That's why... https://github.com/orgs/community/discussions/65321:

When you use the repository's GITHUB_TOKEN to perform tasks, events triggered by the GITHUB_TOKEN (...) will not create a new workflow run.
This prevents you from accidentally creating recursive workflow runs.

Manually triggering a dispatch run to check the availability of the new picture links on this branch succeeded:
https://github.com/Cockatrice/Magic-Token/actions/runs/8130045855

@github-actions github-actions bot force-pushed the ci-update_image_links branch 2 times, most recently from de06f40 to 675fda0 Compare March 4, 2024 20:18
@github-actions github-actions bot force-pushed the ci-update_image_links branch from 675fda0 to 261ae4f Compare March 15, 2024 00:29
@tooomm tooomm closed this Mar 16, 2024
@tooomm tooomm reopened this Mar 16, 2024
@tooomm
Copy link
Contributor

tooomm commented Mar 16, 2024

Note:
Closing and reopening also triggers related workflows and make them even shop up in the PR as usual (that was not the case when manually triggering the workflow on the underlaying branch of the PR). Probably good & easy workaround 👍

Copy link
Member

@ebbit1q ebbit1q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we can't use the manual trigger?

@tooomm
Copy link
Contributor

tooomm commented Mar 27, 2024

so we can't use the manual trigger?

We can use the workflow dispatch trigger and manually run the picture health check action on the branch of the automatically generated PR:
image
It will just not show the result in the PR nicely listed under "checks" where they normally show up.

It's probably more straight forward to just close and reopen such PR's. That way it triggers, and also shows the result in the "checks" section linked to the PR.

@tooomm tooomm merged commit afc4168 into master Mar 27, 2024
@tooomm tooomm deleted the ci-update_image_links branch March 27, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants