Add cmc and manacost to 40K Squad tokens #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebbit1q
reviewed
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
Squadkeyword makes an exact copy of a card, any token made withSquadshould have a cmc and mana cost equal to its parent card. While there are cards withSquadin a few sets (40K, LTC, and PIP), only the 40K cards come with printed tokens that are intokens.xml. I have updated those tokens with appropriate cmc and mana costs.Both
EmbalmandEternalizealso make copies of the parent card and have printed tokens intokens.xml, but both keywords specify that the resulting token has a mana cost of 0 so no change is necessary there.