-
Notifications
You must be signed in to change notification settings - Fork 19
Conversation
Shouldn't the env for the containers be set in the docker-compose file? |
Yes, you are absolutely right. I 'll update it first thing in the morning! |
Could you please also add a documentation on how to run the development environment in the README.md? Otherwise I don't see any problem to merge this. Good work 👍 |
Yes, I ll. I had planned to do so after having proper Docker setup. I have another minor update to make and then I'll have the README.md file updated. And thank you for your kind encouragement. 🙂 |
I might have to set up this whole thing again and submit new PR. I don't even remember what I did so far. I 'll just leave this PR for ref for now. |
@CodingCreate101 Should this be closed? Or do you want to wait until #87 is merged? |
I'd like to wait until the other one is merged if that's okay. I'd like to have this a reference, yet. |
Closing the PR. Please keep the branch, though. |
No description provided.