Upgraded the project to Vue2 #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now using Vue2 and up-to-date packages. Other changes including: 0. Renamed text.vue to text-input.vue to avoid naming conflict with HTML element 1. Re-indented files 2. Replaced `debounce` func with the one from lodash 3. Removed all vuex/actions and interact with mutations now 4. Moved all vuex/getters to store.js
Open
asvrada
force-pushed
the
vue2
branch
2 times, most recently
from
f3d95d1 to
9d51da6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check each commit for detailed changes.
The original repo fails to serve as a Vue example project for beginners anymore as it's using Vue 1 that are outdated, as well as many other packages.
And this PR is aimed to upgrade this project to the most up-to-date state, which includes upgrading outdated packages and fixing incompatible codes that package upgrading brings.
Following are changes other than simple package upgrade: