wsd: revert remoteassetpoll, remote_asset_config is no longer needed #11203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It was added to install templates on the fly. After 608d3ca this feature is no longer needed. Templates can be added by defining it in "SharedSetting" and "UserSetting" CheckFileInfo property for admin and user respectively. - This patch reverts all the related commit added in the PR: CollaboraOnline#10463 - List of reverted commits: - Revert "wsd: remoteassetpoll: rename json property "stamp" to "version"" 4d922bb. - Revert "wsd: remoteassetpoll: rename jsonkey "presnt" to "presentation"" 1492f92. - Revert "wsd: remote: adjust templates json object" 2e79ac3. - Revert "wsd: fix: don't start remoteassetconfig_poll if configkey is empty" 26b7530. - Revert "wsd: remove unused `RemoteFontConfigPoll`" 9885bc0. - Revert "wsd: remoteconfig: use `RemoteAssetConfigPoll` for remote_font_config as well" d813277. - Revert "wsd: remoteconfig: support `fontconfiguration` using `RemoteAssetConfigPoll`" d463610. - Revert "remoteassetpoll: remove templates when json entries is removed" 202e4a4. - Revert "wsd: added "RemoteAssetConfigPoll"" 6478e37. - Revert "lokit: mount childroot/tmp/incoming/templates over instdir/share/common/template/presnt" c8e2384. Signed-off-by: Rashesh <[email protected]> Change-Id: I60d0a5103ef8a5eced8a94e8d67569326cb81a5a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was added to install templates on the fly. After 608d3ca this feature is no longer needed. Templates can be added by defining it in "SharedSetting" and "UserSetting" CheckFileInfo property for admin and user respectively.
This patch reverts all the related commit added in the PR: Improve impress templates #10463
List of reverted commits:
Revert "wsd: remoteassetpoll: rename json property "stamp" to "version""
4d922bb.
Revert "wsd: remoteassetpoll: rename jsonkey "presnt" to "presentation""
1492f92.
Revert "wsd: remote: adjust templates json object" 2e79ac3.
Revert "wsd: fix: don't start remoteassetconfig_poll if configkey is empty" 26b7530.
Revert "wsd: remove unused
RemoteFontConfigPoll" 9885bc0.Revert "wsd: remoteconfig: use
RemoteAssetConfigPollfor remote_font_config as well" d813277.Revert "wsd: remoteconfig: support
fontconfigurationusingRemoteAssetConfigPoll" d463610.Revert "remoteassetpoll: remove templates when json entries is removed" 202e4a4.
Revert "wsd: added "RemoteAssetConfigPoll"" 6478e37.
Revert "lokit: mount childroot/tmp/incoming/templates over instdir/share/common/template/presnt" c8e2384.
Change-Id: I60d0a5103ef8a5eced8a94e8d67569326cb81a5a
TODO