chore(iOS): Allow debugging slideshow webview #11219
Open
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our main webview is debuggable in debug mode but we run slideshows in a separate webview - one which wasn't marked as debuggable. That omission prevented it from showing up in Safari's remote debugger Signed-off-by: Skyler Grey <[email protected]> Change-Id: I91ae6318e0a2f735c4cd0b7faf9a9d2b1d00c68a
timar
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our main webview is debuggable in debug mode but we run slideshows in a separate webview - one which wasn't marked as debuggable.
That omission prevented it from showing up in Safari's remote debugger
Change-Id: I91ae6318e0a2f735c4cd0b7faf9a9d2b1d00c68a
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay