Preview 1.82.19 Hotfix Release #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also try next branch instead
This caused by the confusion of the AUMID being overwritten with different value compared to the executable's title and description.
Qodana for .NET13 new problems were found
☁️ View the detailed Qodana report Contact Qodana teamContact us at [email protected]
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| using Microsoft.UI.Xaml; | ||
| using System; |
Check warning
Code scanning / QDNET
Redundant using directive Warning
|
|
||
| // Get the mark file's relative path | ||
| string relativePathDir = Path.GetDirectoryName(localFileInfo.RelativePath) ?? ""; | ||
| string relativePathNameNoExt = Path.GetFileNameWithoutExtension(localFileInfo.RelativePath) ?? ""; |
Check warning
Code scanning / QDNET
'??' condition is known to be null or not null Warning
This to ensure that the main project, Hi3Helper.Win32 can be used as is to any Windows version, since ToastCOM requires WinRT and use a specific TFM for Windows 10 build 1809
Backport a762be2 Co-authored-by: Kemal Setya Adhi <[email protected]>
This reverts commit 83801be.
Due to the changes in the game mechanism, enabling mobile mode (touchscreen) in HSR requires memory injection in which Collapse does not allow (read Contrib Guidelines). So the feature will be disabled for now. Closes #697
Also renamed rtf license name since its unrecognized by GitHub
|
Ready for publish @CollapseLauncher/core-maintainers |
100% reviewed source file: 'en_US.json' on 'es_419'.
100% reviewed source file: 'en_US.json' on 'zh_CN'.
92% of minimum 75% reviewed source file: 'en_US.json' on 'uk_UA'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
100% reviewed source file: 'en_US.json' on 'id_ID'.
88% of minimum 75% reviewed source file: 'en_US.json' on 'ru_RU'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
99% of minimum 75% reviewed source file: 'en_US.json' on 'ja_JP'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
99% of minimum 75% reviewed source file: 'en_US.json' on 'fr_FR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
96% of minimum 75% reviewed source file: 'en_US.json' on 'ko_KR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
86% of minimum 75% reviewed source file: 'en_US.json' on 'pt_BR'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
99% of minimum 75% reviewed source file: 'en_US.json' on 'vi_VN'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
100% reviewed source file: 'en_US.json' on 'ja_JP'.
+ Also make ToastCOM's callback to work (for real this time).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed? - 1.82.19
Changelog Prefixes